On Thu, Mar 11, 2010 at 01:20:46PM -0800, Danek Duvall wrote: > [email protected] wrote: > > > http://cr.opensolaris.org/~johansen/webrev-15119/ > > The change looks fine as is. In transport.py, I'd not bother changing the > integers to strings in the version numbers when raising PkgProtoErrors, as > "%s" % int works just fine.
Actually, the reason that I changed these to strings was that the check in transport/exception.py:265 wasn't adding the version portion of the string if the version was integer 0. If you'd rather I change this check to 'if self.version is not None' or 'if self.version > -1' I can do that, but it seemed easier to just convert the version argument to a string, because the check would work as written. > You also don't need the str() call on line 1547. I will change that. Thanks for taking a look at this. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
