Shawn Walker wrote:

> http://cr.opensolaris.org/~swalker/pkg-15224/

The code in launch.py is getting a bit baroque, what with all the
combining, splitting and recombining of args.  I think what's there is
fine, but the loop on line 66 is unnecessary, and I'd say that the
splitting out of prog from the rest of args isn't all that useful.

I guess I'd rather see

    args = sys.argv[1:]

    if args[0].find ...:
        allow_links = True
        args.append("--allow-links")
    args = ["/usr/bin/gksu", " ".join(args)]

Looks also like we need a dependency on desktop/gksu in
package/pkg/package-manager, but that's another bug.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to