On 04/26/10 14:00, Tim Foster wrote:
Hi all,
Sorry this is so late - I had been hoping to get this request for a code
review sent out last week.
I've got a code review at
http://cr.opensolaris.org/~timf/pkgdepend-smf
that I'd really appreciate a review of please.
Hey, so I haven't had a chance to do a full review, but was glancing
through to see what sorts of dependencies it picks up. As far as I saw,
it's picking up everything that's a service dependency that isn't
optional_all. It definitely shouldn't pick up exclude_all either.
require_any might be debatable. I'd generally switch the logic around to
pick up the dependencies you care about explicitly rather than by exclusion.
The pkgdepend manpage also probably deserves a section on what types of
dependencies it finds.
liane
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
