Hi Liane,

Thanks for taking a peek,

On Tue, 2010-04-27 at 09:11 -0700, Liane Praza wrote:
> Hey, so I haven't had a chance to do a full review, but was glancing 
> through to see what sorts of dependencies it picks up.  As far as I saw, 
> it's picking up everything that's a service dependency that isn't 
> optional_all.  It definitely shouldn't pick up exclude_all either. 
> require_any might be debatable.  I'd generally switch the logic around to 
> pick up the dependencies you care about explicitly rather than by exclusion.

You're absolutely right - I'd intended only require_all dependencies and
had forgotten about exclude_all, sorry.  I'll switch that around, and
re-test and ping the alias when I'm done.

> The pkgdepend manpage also probably deserves a section on what types of 
> dependencies it finds.

No problem, I'll work on that too.

        cheers,
                        tim

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to