On 04/26/10 07:36 PM, johan...@opensolaris.org wrote:
Folks,
The following webrev creates a read-only mirror mode for the depot that
allows it to serve the contents of your /var/pkg/download directory and
advertise its availability via mDNS. The client can be configured to
detect mirrors advertised by mDNS and use them if they're faster than
the depot.
This may help in environments where the main repository is heavily
loaded, but there are many users on the local subnet that may have
copies of the server's content.
Webrev is available here:
http://cr.opensolaris.org/~johansen/webrev-6957/
src/depot.py:
line 149, 219-221, 303-304, 703:
nit; options should be in asciibetical order :)
general:
Why was --file-root needed? This seems somewhat tangenital to
adding mDNS support and there was nothing enlightening in the bugs.
Is this to support /dev and /release sharing a single file area?
src/man/pkg.1.txt:
lines 684-689:
From which image will the content be removed? The current BE, or
target BE, or both during operations such as image-update?
Currently, this only happens in the original BE because the
content cache cleanup is called after be activation in modules/
client/api.py in __finished_execution.
lines 698-703: You may want to define what UUID stands for the first
time it is used.
src/modules/client/imageconfig.py:
lines 47-59: Since you're here, and it's just deletes, it'd be nice to
also address bug 11178 (just delete all references to
PURSUE_LATEST and DISPLAY_COPYRIGHTS).
src/modules/client/transport/exception.py:
line 315: nit; insert newline here
src/modules/server/repository.py:
lines 947-948: Seems like you could drop these and change line 946
to simply set self.file_root instead?
src/svc/svc-pkg-depot:
lines 49-51, 53-56: nit; options in asciibetical order
src/modules/client/transport/mdetect.py:
line 70: Incomplete sentence?
General Comment:
Any chance of this being able to advertise available nfs mounts too
once the client support for filesystem-based access is putback?
What happens when you try to access the BUI index page for a
repository that has no cfg_cache file or that doesn't provide
a publisher prefix and is running in --mirror or --llmirror mode?
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
