Hi Shawn, Thanks for looking at this.
On Thu, Apr 29, 2010 at 12:32:22AM -0500, Shawn Walker wrote: > On 04/26/10 07:36 PM, johan...@opensolaris.org wrote: > >Webrev is available here: > > > > http://cr.opensolaris.org/~johansen/webrev-6957/ > > src/depot.py: > line 149, 219-221, 303-304, 703: > nit; options should be in asciibetical order :) Ok, fixed. In some places these options were not in alphabetical order to begin with, which is why I assumed it was okay to add them wherever I pleased. I've tried to put those places back into complete order. Perhaps we could enforce this consistently to avoid this kind of confusion in the future? > src/man/pkg.1.txt: > lines 684-689: > From which image will the content be removed? The current BE, or > target BE, or both during operations such as image-update? > Currently, this only happens in the original BE because the > content cache cleanup is called after be activation in modules/ > client/api.py in __finished_execution. Thanks, clarified. > lines 698-703: You may want to define what UUID stands for the first > time it is used. Ok, fixed. > src/modules/client/imageconfig.py: > lines 47-59: Since you're here, and it's just deletes, it'd be nice to > also address bug 11178 (just delete all references to > PURSUE_LATEST and DISPLAY_COPYRIGHTS). Deleted. > src/modules/client/transport/exception.py: > line 315: nit; insert newline here Fixed. > src/modules/server/repository.py: > lines 947-948: Seems like you could drop these and change line 946 > to simply set self.file_root instead? Did you mean lines 938 and 939 in __set_repo_root? If so, then yes, I'll have this assign to self.file_root instead. However, the conditional is necessary since I'd like it to be possible for file-root to be outside of repo-root. > src/svc/svc-pkg-depot: > lines 49-51, 53-56: nit; options in asciibetical order Fixed. > src/modules/client/transport/mdetect.py: > line 70: Incomplete sentence? Changed. > General Comment: > Any chance of this being able to advertise available nfs mounts too > once the client support for filesystem-based access is putback? The client will detect any repository that's advertised following our DNS-SD conventions. It wouldn't be a good idea to run a depot to advertise a NFS-mounted file repository. It would be easy enough to write a separate advertiser, though. We can also advertise services through static DNS, if we ever feel the need. > What happens when you try to access the BUI index page for a > repository that has no cfg_cache file or that doesn't provide > a publisher prefix and is running in --mirror or --llmirror mode? Right now I get: 404 Not Found The path '/' was not found. Is there a way to disable the BUI for this mode? There's not really anything to display to human users in the mirror case. Thanks -j _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
