Danek Duvall wrote:
Saurabh Vyas wrote:
New webrev : http://cr.opensolaris.org/~saurabhv/fix-15646-rev-2/
trans_import also calls gen_actions, and should be robustified against the
same problem.
ActionDataError is definitely not the right exception to raise. Frankly,
I'd leave gen_actions() alone and have the callers deal with IOErrors and
TypeErrors themselves. They're different error conditions, and should have
different messages associated with them.
Thanks Danek,
So I need to handle the TypeError in both trans_import() &
trans_generate() (and nothing in gen_action()), is my understanding right ?
~Saurabh
publish.py:
- line 469: continued lines should have an extra four spaces of indent.
And boolean operators (like the "and" at the beginning of this line)
should be put at the end of the previous line instead, if possible.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
