Saurabh Vyas wrote:
> http://cr.opensolaris.org/~saurabhv/fix-15646-rev-5/
This is looking better, thanks.
publish.py:
- You're still using tabs in a handful of places. The lines where you do
are bizarrely indented. Please be sure to get this correct.
- line 481: wrong subcommand
- line 454, 485: sorry for the bikeshedding, but I'd like to see the
default message tweaked just a little. Please use
error("%s: '%s'" % (e.args[1], e.filename), cmd="...")
as that'll skip the useless "[Errno 2]" part of the message.
You have a couple lines in your testcases which have trailing spaces.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
