On 05/30/10 08:56 PM, Tim Foster wrote:
Hi all,
I've got one more webrev of the SMF pkgdepend bits here. This
webrev merges with Brock's recent pkgdepend multiple-proto-area
putback.
http://cr.opensolaris.org/~timf/pkgdepend-smf-v3
src/modules/flavor/smf_manifest.py:
line 39ff: nit: s/Smf/SMF/g
line 81: s/authoriatitive/authoritative/
line 107: insert additional newline
lines 129-132: wrap at 80; can you check the rest of the file too?
line 148: s/dependends/depends/
lines 177-179: simplify to:
manifests.update(search_smf_dic(fmri, instance_mf))
lines 181-183: simplify to:
manifests.add(search_smf_dic(fmri,
SmfManifestDependency.instance_mf))
line 188: stray newline?
line 194: drop the else
line 195: this seems weird; is it really ok to return any arbitrary
element of manifests? pop() won't necessarily return the last
item added to a set
lines 317-318: s/we make/makes/ s/FMRIs/FMRIs;/ ?
line 324: actually, a tuple of None, None
src/tests/api/smf_manifests.py:
Hmmm; where's the actual unit tests?
src/tests/api/t_dependencies.py:
line 760: why pass a tuple here instead of single value?
line 998-1001: Why assert an always False condition? I think you
really want something like:
self.assert_(dep in deps[fmri], "%s not found in "
" dependencies for %s" % (dep, manifest))
line 1165: insert newline
src/util/distro-import/importer.py:
Does this all work now when accessing a repository using 'file:' ?
It doesn't appear to given lines 749-777.
line 1078: can you use mkdtemp() or the like instead of hard-coding
/tmp ?
lines 1110-1114: simplify to:
return [pkg.fmri.PkgFmri(pfmri) for pfmri in fmris]
line 1533: s/+/ + /
line 1859: s/local_smf_manifests/local_smf_manifests, True)
(Since it doesn't matter if the directory doesn't exist or can't
be removed.)
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
