On 06/ 1/10 03:09 AM, Tim Foster wrote:
Hi Shawn,
Thanks for taking a look - it's much appreciated.
On Mon, 2010-05-31 at 16:32 -0700, Shawn Walker wrote:
http://cr.opensolaris.org/~timf/pkgdepend-smf-v3
src/tests/api/t_dependencies.py:
line 760: why pass a tuple here instead of single value?
That looks like a copy/paste error on my part - it's also present in the
existing variants tests. I've fixed it here and elsewhere.
Please don't change this. d.dep_key() returns a tuple. If you don't pass
d.dep_keys() inside yet another tuple, you get this error:
TypeError: not all arguments converted during string formatting
In other words, the tuple there and other places is deliberate.
[snip]
Brock
Yep, fair point. I've got updated webrevs with these changes at:
http://cr.opensolaris.org/~timf/pkgdepend-smf-v4
http://cr.opensolaris.org/~timf/pkgdepend-smf-v4-vs-v3
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
