On 06/ 7/10 07:11 PM, [email protected] wrote:
On Mon, Jun 07, 2010 at 06:57:09PM -0700, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issue:
16190 file_manager can fail during synchronous file inserts
webrev:
http://cr.opensolaris.org/~swalker/pkg-16190/
This generally looks good.
file_manager.py:
- lines 128, 200, 264: Nit: The backslash isn't needed if the expression is
in parens.
Sure.
General question:
- Is there a test-suite module for the file manager? If so, can you add
a test? If not, can you file a bug to create such a module for the
test suite?
There's a test suite module under tests/api/t_file_manager.py.
Since this test is timing sensitive (it would require two separate
processes or threads both trying to insert a file into a file_manager
directory at the same time), I wasn't certain if adding something to the
existing test suite was valuable or practical, although I can certainly try.
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
