Shawn Walker wrote:

>   http://cr.opensolaris.org/~swalker/pkg-16190/

line 129: four space indent

I'm not sure why you're re-raising if the directory you failed to make
isn't the last in the chain.  Is it that you'd rather see an EEXIST stack
trace if this happens rather than an ENOENT stack if the later rename fails
because of a missing directory?  I would think that the latter is
marginally less likely, at least in the event of hitting the EEXIST in the
first place, but I doubt it matters too much.  If nothing else having a new
EEXIST stack trace might point people back at this bug, giving an incentive
to open a new one for the complete fix.

It would be worth a short discussion in the bug that a) you're not
implementing a complete fix and b) the remaining problems, and c) why
you're not worrying about this for now.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to