On 06/28/10 01:11 PM, [email protected] wrote:
On Sun, Jun 27, 2010 at 08:07:39PM -0700, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-11611-v1/
I only looked at the transport and transaction bits, but I do have a few
questions:
- In publish/transaction.py, you've added three new operations append,
add_cert, and close_append. Why are append and close_append
necessary? Shouldn't it be possible to add functionality to open,
such that all you need is add_cert? Perhaps I'm being dense, but it
seems like it ought to be possible to pass an option to open that
would allow it to append in the cert case instead.
- Does pkgsign have to be its own utility? Could this functionality be
placed in publish.py (pkgsend) instead?
J and I discussed these issues offline and decided that for the moment,
we'll leave things as they are.
- Your copyrights are wrong:
- sign.py (This should be 2010, not 2007, 2010)
- signature.py (This should be 2009, 2010, not 2010)
- publish/transaction.py (This should be 2007, 2010, not 2010)
- server/transaction.py (This should be 2007, 2010, not 2009, 2010)
Thanks, I'll fix those. I'm not sure how I messed those up.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
