On 06/28/10 04:36 PM, Tim Foster wrote:
Hi Brock,
I took a quick look at this,
On Sun, 2010-06-27 at 20:07 -0700, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-11611-v1/
You're adding
src/util/distro-import/138/common/pkg5-dev
- I guess this really should be the build number we're putting back
into, rather than 138 necessarily, or is it that we're happy for nv_138
to be the minimum supported system to build the gate on?
I'll change this to be whichever build I end up targeting for putback.
We were at 138 when I realized the changes needed to be made, so that
was where I put them.
Do we need to perform packaging M2crypto or is that already an open item
elsewhere?
There were a couple of things I knew I needed to do that didn't make it
into this webrev, but I forgot to call them out in the email. Packaging
M2Crypto is one. Fixing the test cases not to use things in my home
directory is another. I'll be doing those before I send out a second
webrev. Given the scope of these changes, I thought it made sense to get
an initial webrev out and working.
There's a few cases where there's blank lines just containing
whitespaces,
grep '^+ *$' recommit.bug-11611-v1.patch
Thanks, I'll make sure to pull these out.
src/modules/actions/signature.py defines a new attribute "pkg.hashalg" -
is this specific to signature actions, or could it be confused with the
algorithms used to hash action/file content? (maybe 'pkg.sig_hashalg'
instead?)
Interesting question and a good point. I'll change it to pkg.sig_hashalg
to make it clear. That way, if/when we support file hashes other than
sha1, we can use the same attribute on the certificate hashes contained
within the signature action.
src/tests/api/t_repositoryconfig.py line 188 and 189 and 268.. look like
they have some debug code commented out, either remove it or print it
using<Pkg5TestCase object>.debug(..)
Bleh, I thought I'd caught all that. Thanks for picking this up, I'll
pull it out.
Is doc/signed_manifests.txt consistent with the changes in this webrev?
I'll take a look and make sure it's consistent.
- that's about all I have for now, I haven't really played with the
built version of the code yet I admit.
Thanks for taking a look!
Brock
cheers,
tim
[snip]
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
