On 08/ 2/10 04:00 PM, Danek Duvall wrote:
[email protected] wrote:
What bit of code catches EnvrionmentErrors that are ENOENT on retry? I
wasn't able to find that bit of code in the code review. I'm assuming
this is already handled elsewhere by an existing exception handler?
That's a loose end I'd chosen not to tie up ("This won't help if you
install a package that never drags in /etc/passwd and friends"), but I
suppose it's easy enough to raise an ActionExecutionError in this case:
http://cr.opensolaris.org/~dduvall/pkg-primordial-2/
src/modules/actions/group.py:
update copyright
src/modules/actions/user.py:
update copyright
src/modules/cfgfiles.py:
update copyright
line 309: should this be "self.lockfd = None" ? Shouldn't lockfd be
set to None during __init__ so that if unlock is called without
lock it doesn't fail with an attribute error?
src/modules/client/image.py:
lines 213-220: So why not store these in the imageplan instead and
reference self.imageplan to get at them in the get_* methods?
I suppose either direction has its tradeoffs and I don't have a
particular preference, so I'll leave it up to you.
Otherwise, seems right to me.
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
