Shawn Walker wrote: > > http://cr.opensolaris.org/~dduvall/pkg-primordial-2/ > > src/modules/actions/group.py: > src/modules/actions/user.py: > src/modules/cfgfiles.py: > update copyright
Thanks. > line 309: should this be "self.lockfd = None" ? Yes, thanks. > Shouldn't lockfd be > set to None during __init__ so that if unlock is called without > lock it doesn't fail with an attribute error? It's already there. > src/modules/client/image.py: > lines 213-220: So why not store these in the imageplan instead and > reference self.imageplan to get at them in the get_* methods? > I suppose either direction has its tradeoffs and I don't have a > particular preference, so I'll leave it up to you. Putting them in the image seems to make more sense to me; they're an attribute of the image, and pulling them from the imageplan when doing the lookups seems like unnecessary pretzelling. I can see an argument to be made from the other side, but it's not terribly compelling to me at the moment. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
