hi all, I'm still working on a few more unit tests for pkglint, after which I'll have a new webrev, sometime this week. Not much has changed in the tool, here's a list of the stuff that will be in the next webrev along with the unit tests:
* lint messages now go to stderr, not stdout * slightly nicer lint & CLI output * an attempt to check that local manifest files are in UTF-8 * better handling of invalid CLI options In the meantime, here's the lint output for nv_145: http://cr.opensolaris.org/~timf/pkglint-webrev-1/sorted-lint-errors-nv_145.txt A few things jump out from this list: * legacy action checking should probably report problems like the one below as warnings, not errors: there's a lot of these - we've never had individual legacy packages for a lot of packages. The combination of user/root packages also contribute to the noise here. ERROR pkglint.action003.2 unable to find ancestor SUNWespeak-devel marked in the 'pkg' attr of legacy action in pkg://opensolaris.org/library/speech/[email protected],5.11-0.145:20100730T020213Z * lots of 'unusual mode' warnings, eg. WARNING pkglint.action002.2 unusual mode 4511 in usr/bin/sudo delivered by pkg://opensolaris.org/security/[email protected],5.11-0.145:20100730T021558Z I suspect this lint check could be tightened a bit. The list of methods implementing checks are, t...@linn[7948] pkglint -L opensolaris.action.001 pkg.lint.opensolaris.OpenSolarisActionChecker.username_format opensolaris.manifest.001 pkg.lint.opensolaris.OpenSolarisManifestChecker.missing_attrs pkglint.manifest.005 pkg.lint.pkglint_manifest.PkgManifestChecker.duplicate_deps pkglint.manifest.006 pkg.lint.pkglint_manifest.PkgManifestChecker.duplicate_sets pkglint.manifest.004 pkg.lint.pkglint_manifest.PkgManifestChecker.naming pkglint.manifest.001 pkg.lint.pkglint_manifest.PkgManifestChecker.obsoletion pkglint.manifest.002 pkg.lint.pkglint_manifest.PkgManifestChecker.renames pkglint.manifest.003 pkg.lint.pkglint_manifest.PkgManifestChecker.variants pkglint.action.005 pkg.lint.pkglint_action.PkgActionChecker.dep_obsolete pkglint.action.003 pkg.lint.pkglint_action.PkgActionChecker.legacy pkglint.action.005 pkg.lint.pkglint_action.PkgActionChecker.license pkglint.action.001 pkg.lint.pkglint_action.PkgActionChecker.underscores pkglint.action.004 pkg.lint.pkglint_action.PkgActionChecker.unknown pkglint.action.002 pkg.lint.pkglint_action.PkgActionChecker.unusual_perms pkglint.dupaction.003 pkg.lint.pkglint_action.PkgDupActionChecker.duplicate_drivers pkglint.dupaction.007 pkg.lint.pkglint_action.PkgDupActionChecker.duplicate_gids pkglint.dupaction.006 pkg.lint.pkglint_action.PkgDupActionChecker.duplicate_groupnames pkglint.dupaction.009 pkg.lint.pkglint_action.PkgDupActionChecker.duplicate_path_types pkglint.dupaction.001 pkg.lint.pkglint_action.PkgDupActionChecker.duplicate_paths pkglint.dupaction.008 pkg.lint.pkglint_action.PkgDupActionChecker.duplicate_refcount_path_attrs pkglint.dupaction.005 pkg.lint.pkglint_action.PkgDupActionChecker.duplicate_uids pkglint.dupaction.004 pkg.lint.pkglint_action.PkgDupActionChecker.duplicate_usernames Excluded checks: opensolaris.manifest.002 pkg.lint.opensolaris.OpenSolarisManifestChecker.print_fmri cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
