Hi Alan, Thanks for taking a look!
On Mon, 2010-08-09 at 19:35 -0700, Alan Coopersmith wrote: > Tim Foster wrote: > > In the meantime, here's the lint output for nv_145: > > > > http://cr.opensolaris.org/~timf/pkglint-webrev-1/sorted-lint-errors-nv_145.txt > > Besides the things you already mentioned, things I see: > > - This would be more useful if it specifed the directory name: > WARNING pkglint.action002.1 directory action delivered in > pkg://opensolaris.org/system/font/truetype/[email protected],5.11-0.145:20100730T021852Z > with mode=0444 that has no executable bits > > (I suspect it's the one mentioned in 6970780 which is fixed in 146.) Yep, that was it. The message now reads: WARNING pkglint.action002.1 directory action for usr/share/doc/ttf-bpg-georgian/README.txt.bz2 delivered in pkg://opensolaris.org/system/font/truetype/[email protected],5.11-0.145:20100730T021852Z with mode=0444 that has no executable bits > - This should probably exclude renamed/obsolete packages: > > WARNING pkglint.manifest004 last name component kernel in package name > clashes across > pkg://opensolaris.org/system/[email protected],5.11-0.145:20100729T183728Z > pkg://opensolaris.org/x11/[email protected],5.11-0.144:20100716T202247Z > I renamed x11/kernel in 144 since it seemed silly for us to clash on the > kernel > name (and it didn't describe our streams module well anyway) - on my system > installed with 145, "pkg info kernel" unambiguously resolves to system/kernel. > > And that would presumably also resolve this package clashing with its old > name: > WARNING pkglint.manifest004 last name component amp in package name > clashes across pkg://opensolaris.org/[email protected],5.11-0.133:20100216T103323Z > pkg://opensolaris.org/web/[email protected],5.11-0.145:20100730T023515Z Yes, I agree - having altered the package naming check taking into account obsolete and renamed packages, neither of these are reported as warnings anymore. > - These are also known bugs fixed in 146: > ERROR pkglint.dupaction008 path usr/share is reference-counted but has > different attributes across 995 duplicates [CR 6970014] > ERROR pkglint.dupaction008 path var/log is reference-counted but has > different attributes across 11 duplicates [CR 6972645] Oh great, now I've got to add _more_ checks to at least get one un-reported bug out of pkglint :-) I'm suspicious about this error: ERROR pkglint.action003.1 ancestor pkg://opensolaris.org/[email protected],5.11-0.133:20100216T103020Z did not declare a dependency on pkg://opensolaris.org/system/kernel/[email protected],5.11-0.145:20100729T183906Z In this case, SUNWxwmod was renamed to x11/kernel in 0.133, and then renamed again to system/kernel/hardware-cursor, but the legacy package hasn't declared the dependency. When renaming a package like this, do we need to republish the 0.133 version of the package declaring a dependency on what the package is now called, or does pkglint need to follow the dependency trail across renames (which could get ugly) cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
