On 08/30/10 04:57 PM, Brock Pytlik wrote:
...
LGTM in general.
I do wonder whether the change in lines 820-829 should look more like
the code for handling "trust-anchor-directory" (808-814). Silently
dropping values from a list instead of erroring because we got a list
instead of a single value doesn't seem really right to me. If you prefer
what you have now, that's fine with me.
Also, I'd mention is that I wouldn't mind a check someplace where we set
the remove cache content policy to explicitly be False someplace and
make sure that also works as expected. I think there are three cases to
test for, True/False/default, and the t_pkg_install seems to cover two
of those.
This should cover the changes you requested:
http://cr.opensolaris.org/~swalker/pkg-16950/v1-v2.patch
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
