On 08/30/10 05:50 PM, Brock Pytlik wrote:
On 08/30/10 03:47 PM, Shawn Walker wrote:
On 08/30/10 04:57 PM, Brock Pytlik wrote:
On 08/30/10 02:38 PM, Shawn Walker wrote:
Greetings,
The following webrev contains fixes for the following issues:
16950 imageconfig set property silently converts single values to
lists breaking consumers
16951 test needed for flush-content-cache-on-success
16952 property API errors need minor formatting fixes
16953 client_api_versions.txt missing entry for version 43
16954 pkg.client.api compatible_versions needs update
webrev:
http://cr.opensolaris.org/~swalker/pkg-16950/
Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
LGTM in general.
I do wonder whether the change in lines 820-829 should look more like
the code for handling "trust-anchor-directory" (808-814). Silently
dropping values from a list instead of erroring because we got a list
instead of a single value doesn't seem really right to me. If you prefer
what you have now, that's fine with me.
I did it for compatibility with any 146 clients that had a list
written out for single property values. The assumption was that a list
should never be there, so this makes old and new clients work as
expected even for those that used build 146 where this was busted.
However, it seems like the reasonably compromise would be to error if
there's more than one value, but silently forcibly convert single
value lists to a value.
That seems like the right thing to do to me. As a side note, assuming
this was introduced by my changes for manifest signing, that didn't land
until 147.
Ah, I was off by one changeset; you're right.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
