On 09/ 7/10 01:25 AM, Padraig O Briain wrote:
I have checked the GUI related changes and they seem to be fine.
Thanks for taking a look.
However, you forgot to patch updatemanager.py.
Huh, I thought I had got them all, thanks for pointing this out.
Here is a suggested patch for it.
Is this OK or should it always use sys.argv[0] for actual_cmd?
The patch looks like what I would suggest. However, I don't know for
certain whether we want to use the absolute path (which application path
provides) or sys.argv[0] in this case.
In pkg's case, I explicitly don't use the absolute path partially
because it allows us to play tricks in the test suite to improve
coverage. Since we have no tests for updatemanager and the absolute path
is already there, perhaps that's the way to go. My inclination though is
to provide consistency with the other uses and not use the absolute path.
Thanks,
Brock
Padraig
On 09/ 7/10 02:18 AM, Brock Pytlik wrote:
webrev:
http://cr.opensolaris.org/~bpytlik/ips-16852-v1/
Bugs:
16852 pkg should look at its image for certs if active image
lacks certs
16919 pkg should look to image relative directories for certs
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
