Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-16852-v2/
What are the cases where actual_cmd is not set to sys.argv[0]?
api.py:
- line 500: Since actual_cmd is no longer a parameter of plan_update_all,
it should be removed from the method's docstring.
image.py:
- line 299: "the from" -> "the one from"?
- line 306: this isn't used anywhere
- line 307: I'm a bit confused by the logic here. Does
cfg_cache.properties return a path prepended with the image root
automatically? If not, then it looks to me like this doesn't look in
the image if the image isn't mounted at / and has
trust-anchor-directory set, unless the path happens to be set correctly
for wherever it happens to be mounted. Perhaps the join with self.root
should happen first? Remember the problem with os.path.join when the
second argument starts with a slash ...
- line 334,335: self.__trust_anchors.setdefault(s, pkg_trust_anchors[s]) ?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
