On 09/19/10 09:34 PM, Tim Foster wrote:
Hi all,
I've a small pkglint change here, which adds a check for the
info.classification attribute and tweaks the check that looks for
underscores in attribute names.
I'd appreciate a code review if anyone has time please?
http://cr.opensolaris.org/~timf/info-classification-webrev
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
lint/opensolaris.py:
line 95: I wonder if it isn't worth displaying some soft of message
here. The error on line 149 is useful, but then I'm left wondering what
was wrong w/ the file.
191: typo in category
211: the error message says "does contain" should it be "does not contain"?
211-214: This message might be more useful if it clarified which bit
isn't in the classification file, and maybe even showed what the valid
sections were (if it was an invalid section) or what the valid
categories were (if it was an invalid category)?
General comment:
Marking the variables to indicate whether they contain reference data
(ie, data for the file) or the data being validated (ie, the info from
the action) would probably make this easier to read. I got confused
about the difference between components and categories on my first read
through.
Other than that, these changes LGTM.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
