Hi Krister,
On Wed, 2010-09-22 at 15:19 -0700, [email protected] wrote:
> On Thu, Sep 23, 2010 at 09:22:29AM +1200, Tim Foster wrote:
> > http://cr.opensolaris.org/~timf/info-classification-webrev
>
> I asked Danek about this a couple of weeks ago, but his opinion was that
> two reviewers were only necessary for our restricted builds, or when
> additional scrutiny was desireable.
Oh grand. Certainly this lint check I think is fairly harmless in the
overall scheme of things. Thanks for taking a look though.
> I just have nits:
>
> lint/opensolaris.py:
>
> - line 161: this could be simplified to:
>
> or not self.classification_data.sections()
Thanks, fixed.
> lint/pkglint_action.py:
>
> - lines 507 & 508: Should these be pulled up to a variable defined
> somehwere else, or is this the only place where variables with
> underscores are checked?
That's the only place at the moment. If I get around to adding a check
for valid actuators, I might separate out the actuators names from the
other attributes with underscores.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
