Hi Shawn,
On Mon, 2010-11-29 at 13:17 -0800, Shawn Walker wrote:
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-15864/
>
> Logic is:
<snip>
That logic seems sane.
src/client.py, line 3738, lines 1312, 3545, 3572, 3622 (& elsewhere)
There's comments saying various items should be accessible through the
API, but then we still call img.xxx(). Given as img isn't in these
methods (but declared a global before we get here) would it be more
polite to just remove the global, and call api_inst.img.xxx() instead?
Later, once those items are accessible through the API, we could
revisit the code to have it call the new API methods, hiding
api_inst.img.
src/pkgdep.py, line 279
Could the shell-escaping code be shared between pkgdep and client,
perhaps in pkg.misc?
src/tests/pkg5unittest.py
Why don't we need changes to use -R in pkgdepend_resolve(), or have its
callers pass a -R flag in their arguments? That said, I also can't find
what changed in pkgdepend to cause us to need to file 7002405, so I
could well be mistaken here.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
