On 11/30/10 04:01 PM, Danek Duvall wrote:
Shawn Walker wrote:
http://cr.opensolaris.org/~swalker/pkg-15864/
Isn't this an incompatible API change? At the very least, this is an API
change.
It's not an incompatible change in the interface since before this
changeset, the API didn't allow you to enable the 'find an image'
behaviour. It always expected you (per documentation) to pass the exact
path of an image. And before this changeset, the API didn't even allow
you to control whether it would automatically attempt to find an image
or not.
But you're right that I should bump the version number at the least and
add an entry in doc/client_api_versions.txt.
client.py:
- line 600, et al: why not just move the "import warnings" down to the
one place we use it, and not hack up each instance of a perfectly
reasonable variable name just to work around a lint suggestion.
Because we've historically avoided doing imports where we use an item
instead of declaring them all at the top of a source file? No other
reason particularly. I'll change this.
- line 1055: why not
for c in "\\ \t\n'`;&()|^<>?*":
Because it seems weird to use a string as an iterable in Python? :P
Doesn't matter to me though; changed.
- line 1101: I don't think you need this anymore.
Indeed; thanks.
- line 4521: use "is"
Do we have a rule for this yet? My first inclination was to use 'is'
but I thought I recalled being told to use '==' and so did not.
Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
