Shawn Walker wrote: > src/modules/actions/group.py: > lines 163-169: is there a separate bug# for this fix? > > src/modules/actions/user.py: > lines 278-281: is there a separate bug# for this fix?
I didn't run into them separately, so I didn't bother. > src/modules/client/image.py: > line 2832: do you really want set actions too? Covered in private conversation, but the globally_identical test on the next line removes the set and depend actions that come through. It could be more efficient yet, but compared to file and directory action data, set and depend action data is miniscule, so I'm not too concerned about this right now. > line 2873: s/, e:/:/ Should this actually just be "except:" rather than "except Exception:"? > lines 2893-2901: you shouldn't need this since you got the directory > from self.temporary_dir(); it already deals with it What call to temporary_dir()? I could end up in a situation where I was able to create a temporary directory for the temporary names but be unable to move them into place because /var/pkg/cache was unwritable to me for some reason. > lines 2913, 2935, 2947: s/file/open/; "preferred way to open a file" > according to pydoc; also, should probably use "rb"? Heh. We use file a bit more than we do open. And why would "b" matter here -- the file shouldn't ever be transferred between systems and we're reading in pure text data. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
