On 02/ 1/11 04:31 PM, Shawn Walker wrote:
On 02/ 1/11 04:23 PM, Danek Duvall wrote:
Shawn Walker wrote:
...
lines 2913, 2935, 2947: s/file/open/; "preferred way to open a file"
according to pydoc; also, should probably use "rb"?
Heh. We use file a bit more than we do open. And why would "b" matter
here -- the file shouldn't ever be transferred between systems and we're
reading in pure text data.
It just seems preferable to use 'rb' and 'wb' when dealing with these
files so that Python never attempts any EOL transformation. Since 'b' is
a no-op on most platforms, it seems harmless to change.
Oh, and before I forget, since the actions could contain binary data
(unicode), that's probably another good reason.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
