Hi there, Based on feedback from the last round of code review, I've got another cut of the pkgdepend bypass-generate functionality. I have addressed the comments I received from the previous round of code review, thanks again for that.
Here are webrevs, both complete, and incremental from the first code review (since that was the one that most people looked at; the incremental does unfortunately show some diffs unrelated to my changes, as I've merged with the latest pkg-gate tip) http://cr.opensolaris.org/~timf/pkgdep-python-webrev-2 http://cr.opensolaris.org/~timf/pkgdep-python-webrev-0-vs-2 The main functional differences are: * pkg.depend.bypass-generate attribute values are regular expressions * when checking for bypasses, we expand the pkg.debug.depend.file and pkg.debug.depend.path values into pkg.debug.depend.fullpath values, then omit files which match our regular expression (rather than trying to split off dependencies as before, which was slightly hairy) I've done sparc & x86 nightly builds on ON with these bits, using an ON gate which employs both new pieces of functionality, checking that we're generating the same dependencies (without the majority of the pkgdepend errors, bugs filed for everything that's left - 3 failures on sparc, 2 on x86) I have done a full pkg-gate test run too. All comments would be most welcome, thanks. cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
