On 03/20/11 08:34 PM, Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-3617-v1/
t_pkgsign.py:
- line 114: where is set_debug_value set in a call to pkg()?
Bleh, I had that in when I was handling the crl setup slightly
differently, consider it removed.
- line 117: why not put this data in the class during setup?
Because this suite uses api objects to do a lot of the installing an
uninstalling, we needed to put the value in DebugValues anyway for them
to function as expected. Since it was already there, it seemed like a
good place to pull from to set it on the command line.
- line 118: why use ManyDepotTestCase when the class' superclass is
SingleDepotTestCase?
Bad case of copy&paste. Fixed.
pkg5unittest.py:
- line 2003: why reference _base_port instead of next_free_port?
No real reason, I'm happy to switch this and increment next_free_port
inside the loop.
Danek
Thanks for the review!
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
