----- [email protected] wrote: > Shawn Walker wrote: > > > http://cr.opensolaris.org/~swalker/pkg-paths/ > > There are no problems if http urls have weird characters, because the > server takes care of unencoding all that correctly, right? Is it > worth > testing for that?
No, it's expected that the server deals with it. > Your testcase doesn't ensure that the path created is actually the > one > intended, not the url-encoded version. Unless the rmtree would fail > if > "rpath" didn't exist. The rmtree would fail if "rpath" didn't exist. > And why do you use "%s" % rpath on line 1101? It was originally more and I failed to simplify. > The other chunks are just removal of an unused parameter, AFAICT. Yes, is that ok? It's a change in the related function. -Shawn _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
