Shawn Walker wrote:

> > Your testcase doesn't ensure that the path created is actually the one
> > intended, not the url-encoded version.  Unless the rmtree would fail if
> > "rpath" didn't exist.
> 
> The rmtree would fail if "rpath" didn't exist.

Okay, good.

> > The other chunks are just removal of an unused parameter, AFAICT.
> 
> Yes, is that ok?  It's a change in the related function.

Yes; just making sure it wasn't more significant.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to