On 05/ 9/11 03:47 AM, John Rice wrote:
Shawn - thanks for taking a look. I've respun the webrev to reflect your
suggestions. On the testing front I just ran the publisher tests.
Perhaps you or Brock would be better placed to suggest where the tests
need modified to check this output.

Just run the full test suite and see which ones break due to the publisher output changes. I'd have to do that find out where the breakages are.

...
webrev:
http://cr.opensolaris.org/~jmr/cli_18269_pub_sig_policy_may9_1140am/
18269 - CLI should provide a way to view a publishers signature policy
https://defect.opensolaris.org/bz/show_bug.cgi?id=18269

src/client.py:
  line 3818: you can simplify this to simply 'if names:'; python will do
    a length check on the result, and names will always evaluate to
    False if it is None.

Otherwise, LGTM.

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to