Thanks Padraig and Shawn:
New webrev below, which addresses your issues Padraig in PM:
http://cr.opensolaris.org/~jmr/pm_16993_16992_cert_sig_support_may10_445pm/
16993: packagemanger should provide a way to manipulate and see
publisher certs
https://defect.opensolaris.org/bz/show_bug.cgi?id=16993
16992: package manager should provide a way to change signature-policy
https://defect.opensolaris.org/bz/show_bug.cgi?id=16992
Respun the CLI patch given Shawn's comments. I'll run all the tests this
evening as its going to take some time on the low power toshiba I have
got at the minute.
webrev:
http://cr.opensolaris.org/~jmr/cli_18269_pub_sig_policy_may10_450pm/
18269 - CLI should provide a way to view a publishers signature policy
https://defect.opensolaris.org/bz/show_bug.cgi?id=18269
JR
On 10/05/2011 13:57, Padraig O Briain wrote:
John,
misc.py:
Should you change PUBCERT_ORGANISATION to PUBCERT_ORGANIZATION; also
PUBCERT_ORGANISATIONAL_UNIT?
Changed
Should check_sig_required_name_policy call
fetch_signature_policy_names_from_text?
Changed
There are pylint warning from repository.py; line 496 looks wrong.
Fixed
Padraig
On 05/ 9/11 11:47 AM, John Rice wrote:
Shawn - thanks for taking a look. I've respun the webrev to reflect
your suggestions. On the testing front I just ran the publisher
tests. Perhaps you or Brock would be better placed to suggest where
the tests need modified to check this output.
Thanks.
JR
webrev:
http://cr.opensolaris.org/~jmr/pm_16993_16992_cert_sig_support_wip_may09_1145am/
16993: packagemanger should provide a way to manipulate and see
publisher certs
https://defect.opensolaris.org/bz/show_bug.cgi?id=16993
16992: package manager should provide a way to change signature-policy
https://defect.opensolaris.org/bz/show_bug.cgi?id=16992
webrev:
http://cr.opensolaris.org/~jmr/cli_18269_pub_sig_policy_may9_1140am/
18269 - CLI should provide a way to view a publishers signature policy
https://defect.opensolaris.org/bz/show_bug.cgi?id=18269
$ pfexec ./run.py -o t_pkg_pub*
# Accessibility not enabled, GUI tests disabled.
# logging to /tmp/tmpJN148h.pkg-test.log
...............
# ----------------------------------------------------------------------
# Ran 15 tests in 526.493s - skipped 0 tests.
On 06/05/2011 18:52, Shawn Walker wrote:
On 05/ 6/11 08:15 AM, John Rice wrote:
Hi - this webrev implements Certificate Management and Signature
policy
support for PM. I have also attached the latest design notes that
describe what has been implemented.
Certificate Management support is found under:
File-> Manage Publishers: <select pub> Modify button: Modify
Publisher:
Certificates tab
Signature Policy support for both Publishers and Image can be found
under:
File-> Manage Publishers: <select pub> Modify button: Modify
Publisher:
Signature Policy tab
Edit-> Preferences: Signature Policy tab
webrev:
http://cr.opensolaris.org/~jmr/pm_16993_16992_cert_sig_support_wip_may06_345pm/
src/gui/modules/misc.py:
US English spellings please :-)
s/Organisation/Organization/
16993: packagemanger should provide a way to manipulate and see
publisher certs
https://defect.opensolaris.org/bz/show_bug.cgi?id=16993
16992: package manager should provide a way to change signature-policy
https://defect.opensolaris.org/bz/show_bug.cgi?id=16992
In order to see the Publisher Signature Policy settings I have the
following small webrev to update the output from pkg for:
pkg publisher <pub name>
webrev:
http://cr.opensolaris.org/~jmr/cli_18269_pub_sig_policy_may6_4pm/
18269 - CLI should provide a way to view a publishers signature policy
https://defect.opensolaris.org/bz/show_bug.cgi?id=18269
This lists the Signature policy settings for the publisher as below:
pkg -R /var/tmp/testrepos publisher local
src/client.py:
line 3819: If you're going to abbreviate sig, you probably need
'Sig.' instead of 'Sig'. I'd also request that the required names
not be printed as a raw list of Python values. Instead, they should
probably be displayed the same way the list of certs are in
display_signing_certs().
Finally, I would have thought changing the CLI output would break
some of the unit tests that check 'pkg publisher' output. Did you
run the entire test suite?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
