On 05/15/11 21:11, Tim Foster wrote:
Hey Brock,
On Fri, 2011-05-13 at 20:23 -0700, Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-18326-v1/
Bugs:
18326 imageconfig should cope with running pkg operations as an
unprivileged user
18343 pkg publisher pub is broken when pub is a system publisher
That looks good to me - the changes to imageconfig.py look like a bit of
an onion (layered try-catch block), but I don't have a better
suggestion :-)
cheers,
tim
Yeah, I wasn't thrilled about it, but writing it this way meant I needed
one fewer except block, and didn't change the total number of
indentations or try's :)
Thanks for taking a look,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
