On Fri, May 13, 2011 at 02:18:02PM +1200, Tim Foster wrote:
> Hi there,
>
> I've got a set of changes here that I'd appreciate a code review of
> please:
>
> http://cr.opensolaris.org/~timf/sysrepo-refactor-webrev/
>
> 18297 system-repository needs to be enabled more
> 18298 system-repository service should go into maintenance if it doesn't
> understand a file repo
> 18306 system-repository package should be refactored
> 18307 sysrepo service not resilient to failures
> 18309 sysrepo package missing info.repository_changeset and
> info.repository_url values
> 18313 sysrepo svc method needs a comment explaining LD_LIBRARY_PATH
>
> In particular, this refactors the system-repository package, breaking it
> up in to two pieces: 1. the system-repository, and 2. the zones proxy
> client and server, which have appropriate variants so we won't end up
> dragging apache into every zone we create.
>
> Apart from the pkg.sysrepo changes for which I've added a test case,
> I've manually tested our SMF interactions by installing zones on a test
> machine and watching execsnoop output as I change zone state.
>
thanks for doing this. comments below.
ed
---------
general
- not this putback, but could pkg.sysrepo be updated to detect http
redirected repositories and fail in that case as well?
- you still reference the old zoneproxy pkg and svc names in a bunch of
places.
---------
src/brand/common.ksh
- please prefix service names with svc://
---------
src/pkg/manifests/*.p5m
- shouldn't the info.repository* attributes be automatically added via
some kind of pkg mogrify entries? (if there isn't a bug filed on this
perhaps there should be?)
---------
src/svc/svc-pkg-sysrepo
- say that the global zones publisher configuration has been update and
hence a refresh has been triggered. but pkg.sysrepo fails because we
now have an unsupported repository. svc-pkg-sysrepo will return an
error, but it won't kill httpd or htcacheclean. so what happens in
this scenario? will smf kill them off for us? or will the continue
to run with an incorrect configuration?
---------
src/pkg/manifests/system%252Fzones%252Fbrand%252Fipkg.p5m
- should depend on the zones proxy and the system-repository package.
---------
src/pkg/manifests/system%252Fzones%252Fproxy.p5m
- we're still not generating automatic dependencies, right? if so then
this package needs a bunch of manual dependencies. at a minimum we
probably want:
system-repository (gz only)
the packaging system
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
