On 05/16/11 16:05, Edward Pilatowicz wrote:
hey all,

i've got some small bugfixes that need a review:

http://mcescher.us.oracle.com/export/ws/pkg.bugfix1/webrev/

18340 unquoted matching patterns cause spurious test case failures
18341 test suite doesn't cleanup fakeroot
18342 pylint in the build is too noisy, it should only report errors
18358 pkg incorrectly claims child pub config must be subset of parents

ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Is it possible to make it so that make install only shows pylint errors, but make lint shows the verbose reports?

For env_sanitize and fakeroot_fini, why not make these (static?) methods of the Pkg5TestCase class? (Also, the name fakeroot_fini seems a bit strange to me, but to each their own)

Other than that, lgtm.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to