On 05/17/11 18:07, Edward Pilatowicz wrote:
On Tue, May 17, 2011 at 10:28:51AM -0700, Brock Pytlik wrote:
On 05/16/11 16:05, Edward Pilatowicz wrote:
hey all,
i've got some small bugfixes that need a review:
http://mcescher.us.oracle.com/export/ws/pkg.bugfix1/webrev/
18340 unquoted matching patterns cause spurious test case failures
18341 test suite doesn't cleanup fakeroot
18342 pylint in the build is too noisy, it should only report errors
18358 pkg incorrectly claims child pub config must be subset of parents
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
Is it possible to make it so that make install only shows pylint
errors, but make lint shows the verbose reports?
sure. done.
For env_sanitize and fakeroot_fini, why not make these (static?)
methods of the Pkg5TestCase class?
well, they update and use globals, so i kinda thought they should be
globals themselves?
ok, thanks for the explanation.
(Also, the name fakeroot_fini seems a bit strange to me, but to each
their own)
yeah. i had init, i consider fini to be the reciprocal to that. but i
agree it sounds weird. i renamed them to _create/_destroy.
I like these better :)
the webrev has been updated.
Lgtm.
Brock
ed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
