On 06/08/11 10:17, Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/1769/
1769 pkg(5) doesn't check for disk space
http://defect.opensolaris.org/bz/show_bug.cgi?id=1769
general:
use misc.bytes_to_str() instead of humanize(); don't really want more
than one of these methods :( or was there something specifically wrong
with it? Can you remove api_errors.humanize()?
src/modules/client/api.py:
lines 4283-4298: I was hoping these would be properties, just like
lines 4397-4420.
line 4288: perhaps a note about this being used for the download cache?
src/modules/client/api_errors.py:
line 157: insert newline before this
lines 163-164: Perhaps:
"Insufficient space available (%(avail)s) for '%(use)s'. Estimated
space required: %(needed)s."
src/modules/client/imageplan.py:
line 300: s/bytes/compressed bytes/ ?
line 301: s/bytes/cbytes/
line 309: s/compressed space/compressed bytes space available/ ?
line 310: s/bytes_added/cbytes_avail/
lines 1436-1437: actually, this should be image.__write_cache_root
(if set) and if that isn't set image.__write_cache_dir. You'll need to
add properties to image.py to make those accessible to imageplan.py or
change them from private to protected (leading __ to _).
line 1441: extra newline
src/modules/client/pkgplan.py:
line 368: insert newline after
src/modules/misc.py:
lines 1080-1083: extra newlines?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
