On 07/17/11 21:38, Tim Foster wrote:
Hi there,
I've got an updated webrev here that makes pkglint check the file
actions are using the overlay attribute properly:
https://cr.opensolaris.org/action/browse/pkg/timf/pkglint-overlay-validate-v2/pkglint-overlay-validate-webrev-v2/
The code went through a few rewrites to get to this stage, so it doesn't
make sense to include an incremental webrev here.
Comments would be most welcome,
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
pkglint_action.py:
594-596: i have an intuition for what the overlay and allow_overlay
lists will hold. I don't have the same intuition for ret_actions, and
the code from 601-616 doesn't make it obvious (to me). Could it be
renamed or a comment added to explain what kind of actions are expected
in it?
672: is this assertion saying that I can't allow an overlay on a file
without having at least one package deliver an action which overlays on
it? That seems a bit restrictive to me. If this is a check we do want,
then it seems strange to me that we only check that there is some
variant combination under which an overlay is delivered, instead of all
variant combinations. (For example, if I had a overlay=allow action that
was delivered under all variants, but a overlay=true that was delivered
only on debug, sparc, this check would pass, which seems a bit odd to me.)
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
