On 07/27/11 16:18, Tim Foster wrote:
Hey Brock,
Thanks for the review,
On Wed, 2011-07-27 at 15:52 -0700, Brock Pytlik wrote:
https://cr.opensolaris.org/action/browse/pkg/timf/pkglint-overlay-validate-v2/pkglint-overlay-validate-webrev-v2/
pkglint_action.py:
594-596: i have an intuition for what the overlay and allow_overlay
lists will hold. I don't have the same intuition for ret_actions, and
the code from 601-616 doesn't make it obvious (to me). Could it be
renamed or a comment added to explain what kind of actions are expected
in it?
Sure. This method gets passed a bunch of actions which deliver to the
same path. It's job is to remove all valid overlay actions, and return
the actions which do not declare valid overlays - those actions get
stored in ret_actions. I'll add a comment.
672: is this assertion saying that I can't allow an overlay on a file
without having at least one package deliver an action which overlays on
it?
Nope - because the method is only called when we have more than one
action delivering to the same path. If we only have a single
overlay=true, or a single overlay=allow action, we don't hit this code
path at all.
If we have mutiple overlay=true or overlay=allow actions, or actions
that don't use overlays we'll complain if they're not complimentary.
This gets tested quite a bit in
https://cr.opensolaris.org/action/browse/pkg/timf/pkglint-overlay-validate-v2/pkglint-overlay-validate-webrev-v2/src/tests/api/t_pkglint.py.html
eg. line 1153, the manifest overlay-valid-simple-no-overlay.mf
cheers,
tim
Sounds good to me :)
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
