On 07/22/11 14:25, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/18439-v1
Bug:
18439 pkg commands that modify the image should have a parsable output
option
src/client.py:
lines 102-1111: This doesn't seem to include the license text?
lines 1117-1129: I'd personally suggest naming these in terms of what
will be done instead of as if they had been already done. That is,
'create-new-be' instead of 'new-be-created' (we also seem to be missing
be-name if one was specified). Or, 'activate-be' instead of
'be-activated'. I'd also suggest 'removed-packages' instead of
'removed-fmris' and so on. But these are mostly bike-shedding suggestions.
line 1106: shouldn't this be dest_tup = None?
line 1130: Maybe add a comment that it's always None for parent
images or am I misunderstanding?
line 2521: should this be included in the if condition above? doesn't
seem like it should be output
src/modules/client/api.py:
line 866: missing space after 'True,'
lines 1026-1027: now we're yielding some sort of custom dictionary?
That's also not documented in the docstring, and why aren't we returning
some kind of PlanDescription object instead?
src/modules/client/imageplan.py:
line 244: docstring should be moved to just after 297 now, and a new
one added
src/tests/cli/t_pkg_revert.py:
line 132: s/C,/C, /
general: I'm going to assume that if --parsable is specified, there is
no other output from the client except JSON and that the
QuietProgressTracker is always used. I'm also going to assume
--parsable was intentionally not documented in in usage or pkg(1).
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
