On 07/28/11 14:25, Brock Pytlik wrote:
On 07/27/11 23:33, Shawn Walker wrote:
On 07/22/11 14:25, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/18439-v1
Bug:
18439 pkg commands that modify the image should have a parsable output
option
src/client.py:
lines 102-1111: This doesn't seem to include the license text?
It wasn't clear to me that having the license text was needed. If it
should be there, I'm happy to add it.
Since the license text won't be output, but the client will have claimed
to have displayed it, I think we're sort of obligated to include the
text. I have no idea how this is going to be presented in the user
interface that's consuming this.
I think it's likely important to include the license text since the
license text output by the client here is only licenses that were
changed as part of the operation, as opposed to all licenses for the
package that you can get with info --licenses.
src/modules/client/api.py:
line 866: missing space after 'True,'
lines 1026-1027: now we're yielding some sort of custom dictionary?
That's also not documented in the docstring, and why aren't we
returning some kind of PlanDescription object instead?
Sure I'll update the docstring. We're not returning a PlanDescription
object because Ed's doing a lot of work in that area and I saw no reason
to duplicate his efforts. I also saw no reason to go through the effort
of converting the dictionary into a PlanDescription object then back to
the exact same dictionary I'd just converted.
This will all need to change to reflect Ed's changes, but hopefully not
too substantially. In the interest of landing this in the appropriate
time, I made those decisions.
That's fine.
src/tests/cli/t_pkg_revert.py:
line 132: s/C,/C, /
general: I'm going to assume that if --parsable is specified, there is
no other output from the client except JSON and that the
QuietProgressTracker is always used. I'm also going to assume
--parsable was intentionally not documented in in usage or pkg(1).
Yep on both counts.
I'm willing to consider documenting them, and if we ever do a
better/more general v1 parsable output, I'd probably be in favor of
documenting it. Since it's explicitly designed for a single consumer,
I'm inclined not to document it.
Not documenting it is fine with me, since I hope it will be extremely
short lived.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
