On 11/18/11 18:04, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/19055-v1

Bug:
19055 providing multiple exact fmris breaks pkgsign

src/modules/catalog.py:
What effect do the changes on 3283-3284 have? It's not immediately clear. If the changes are important, a comment needs to be added explaining.

I don't agree with removing the multispec pattern error code; I think it needs adjustment to allow it only in specific circumstances, otherwise, it permits ambiguous pattern matching which is not desirable. I think we need to work this out off-line in more detail. I'm particularly concerned about the affect on 'pkgrepo remove'.

The rest of the changes are correct at current but would obviously need changing based on the discussion above.

-Shawn

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to