On 11/21/11 12:00, Brock Pytlik wrote:
On 11/21/11 11:47, Shawn Walker wrote:
On 11/18/11 18:04, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/19055-v1
Bug:
19055 providing multiple exact fmris breaks pkgsign
src/modules/catalog.py:
What effect do the changes on 3283-3284 have? It's not immediately
clear. If the changes are important, a comment needs to be added
explaining.
The changes on 3283-3284 make sure that if a pattern matched multiple
items, they get propagated through, instead of overwriting one another.
I'm happy to add a comment to make that clearer.
I don't agree with removing the multispec pattern error code; I think
it needs adjustment to allow it only in specific circumstances,
otherwise, it permits ambiguous pattern matching which is not
desirable. I think we need to work this out off-line in more detail.
I'm particularly concerned about the affect on 'pkgrepo remove'.
Fine, let's discuss this offline.
Brock and I discussed this offline (with Bart) and believe this change
can go forward as-is (minus the addition of a comment to the catalog
matching code).
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
