On 12/02/11 14:06, Shawn Walker wrote:
On 11/29/11 16:34, Brock Pytlik wrote:
On 11/08/11 18:56, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/bug-19009-v1
Bugs:
19009 pkgdepend can't decide which gcc runtime version to output so
errors out instead
19029 pkgdepend should validate manifests' actions
19034 removal of require-any dependency gets direction of comparison
wrong
19037 resolve shouldn't combine conditional deps with different
predicates
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
I've resynced the webrev against the tip:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/19009-v2
src/modules/publish/dependencies.py:
lines 186-191: suggest this text instead (note the de-capitalization):
pkgdepend has inferred conditional dependencies with different targets
but which share a predicate. pkg(5) can not represent these
dependencies. This issue can be resolved by changing the packaging of
the links which generated the conditional dependencies so that they
have different predicates or share the same FMRI. Each pair of
problematic conditional dependencies follows:
I like that, thanks.
line 602: can you add a comment about what this check is doing?
Sure. And oops, I realized that I'm now dropping the license actions,
I'll fix that.
line 947: Why not default seed to 'misc.EmptyI' instead? Is None ever
explicitly passed/expected?
Hrm, while I needed seed at some point during the writing of this code,
I think I ended up rearranging it so that it wasn't needed, I'll remove it.
src/tests/cli/t_pkgdep_resolve.py:
line 1078: s/, varianted,/ varianted/ ?
I think the commas are right there, at least it matches how I intend
that sentence to be read. (I believe what the commas do is that they
make it clear that two is not modifying varianted.)
line 1080: s/the/that/ ?
Yep
line 3068: extra newline
Is it intentional that many of the test_remove_paths have an
identical docstring?
Yep.
You should get another reviewer; I'm not sure I understood everything.
Thanks for taking a look, I'll try to round up one more person.
Brock
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
