Hey Brock,
On 12/ 6/11 01:37 PM, Brock Pytlik wrote:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/19009-v3
Just taking a look at this - this was pretty tough to review,
dependencies.py is one of the more complex parts of our code I feel -
perhaps I'm just not familiar enough with it yet.
I wonder if this code is sufficiently complex that it warrants a more
general discussion of the approach to be put in
./doc/pkgdepend-primer.txt or somesuch?
In the meantime here's some comments:
src/modules/publish/dependencies.py
line 846, 950 - array indices are hard to read here, could we use a
named tuple here instead?
line 852, 1303 - typo 'dependency'
line 870 - similarly, array indices are hard to deal with
l[0][2]?(l[0][2] corresponds to t[4] from line 846, right?)
line 950 - the comment here is terse - could it explain a bit more what
it's trying to do when grouping? I was a bit lost in here, I admit.
line 1215 - 'require any' should be 'require-any' right?
line 1270 - I don't see why you're skipping the order of the
is_successor check from the previous version of the code? If this is
correct, then does the comment at 1266 still hold?
line 1383 - extra space in the block comment I think
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
