On 01/22/12 18:29, Edward Pilatowicz wrote:
hey all,could i get a review for: https://cr.opensolaris.org/action/browse/pkg/edp/pkgstate_cleanup/webrev 19148 PKG_STATE_* defines need a new home
I don't think that pkg.client.pkgdefs is a great place for these constants. Our module namespace in general is a bit mixed up right now :-( (The server/client distinction is largely meaningless.)
It feels like this belongs in a more generic pkg.defs module or the like, but seeing as how much of a mess we have in general that needs to be fixed, it's probably ok to move them here for now.
Otherwise, LGTM. -Shawn _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
