On Mon, Jan 23, 2012 at 01:14:14PM -0800, Shawn Walker wrote: > On 01/23/12 13:03, Brock Pytlik wrote: > >On 01/22/12 18:29, Edward Pilatowicz wrote: > >>hey all, > >> > >>could i get a review for: > >> > >>https://cr.opensolaris.org/action/browse/pkg/edp/pkgstate_cleanup/webrev > >>19148 PKG_STATE_* defines need a new home > >> > >>thanks, > >>ed > >>_______________________________________________ > >>pkg-discuss mailing list > >>[email protected] > >>http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > >This LGTM. Am I correct that the only semantic changes are that > >PKG_STATE_RENAMED, PKG_STATE_OBSOLETE, and PKG_STATE_UNSUPPORTED in > >catalog.py have gone from being 0, 1, 2 to being 8, 9, 10? > > Which, for the record, should be fine in this particular case since > those states were not stored anywhere -- they were strictly used for > consumers of the catalog pattern matching interfaces. >
cool. thank you both for the review. ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
