You don't really describe in the bug how PUBLISHALL is broken and
ALL_MANIFESTS is incomplete, so I don't know how to evaluate your fix. As
far as I can tell, the only substantive change is the exit 0, but that's
got to be a teeny corner case.
Sorry, I realize it was a bit terse. The issue was that the shell
construct was called ALL_MANIFESTS:sh rather than the expected
ALL_MANIFESTS.<something> and then on the next line, we don't actually
end up evaluating the shell fragment at all. So the fix is to rename
the construct along the lines of the other cases in the Makefile and
then properly evaluate it using $(ALL_MANIFESTS.cmd:sh).
ALL_MANIFESTS.cmd = \
.
.
.
ALL_MANIFESTS = $(ALL_MANIFESTS.cmd:sh)
To be consistent with the other examples, I also broke this up into
separate lines.
Also note that there's no need to put diffs into the suggested fix. That's
why we put changeset ids into the bug.
Aye, just habit out of using Bugster.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
